From 510106bb7d008440138d16b92020fe03fadd1643 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A1rk=C3=B6zi=20Gergely=20J=C3=A1nos?= <cycss7@inf.elte.hu> Date: Tue, 3 May 2022 23:25:35 +0200 Subject: [PATCH] fix warnings, apply suggestions --- Assets/Scripts/Logic/Data/World/Unit.cs | 3 +-- Assets/Scripts/LogicTests/GameOverviewTest.cs | 1 - Assets/Scripts/LogicTests/GameTestUtils.cs | 2 +- Assets/Scripts/Presentation/UI/MainMenu.cs | 2 +- Assets/Scripts/Presentation/UI/TowerPlacingUI.cs | 4 ++-- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Assets/Scripts/Logic/Data/World/Unit.cs b/Assets/Scripts/Logic/Data/World/Unit.cs index 9237940..b9424df 100644 --- a/Assets/Scripts/Logic/Data/World/Unit.cs +++ b/Assets/Scripts/Logic/Data/World/Unit.cs @@ -1,5 +1,4 @@ -ďťżusing System; -using System.Collections.Generic; +ďťżusing System.Collections.Generic; using System.Linq; using Logic.Event.World.Unit; diff --git a/Assets/Scripts/LogicTests/GameOverviewTest.cs b/Assets/Scripts/LogicTests/GameOverviewTest.cs index 44b07a6..0ac2cdc 100644 --- a/Assets/Scripts/LogicTests/GameOverviewTest.cs +++ b/Assets/Scripts/LogicTests/GameOverviewTest.cs @@ -1,7 +1,6 @@ ďťżusing System; using System.Linq; using Logic.Command; -using Logic.Command.Unit; using Logic.Data; using NUnit.Framework; diff --git a/Assets/Scripts/LogicTests/GameTestUtils.cs b/Assets/Scripts/LogicTests/GameTestUtils.cs index aba6a1d..a6d6740 100644 --- a/Assets/Scripts/LogicTests/GameTestUtils.cs +++ b/Assets/Scripts/LogicTests/GameTestUtils.cs @@ -154,7 +154,7 @@ public static class GameTestUtils { public int BuildingCost { get; set; } = 3; public int DestroyRefund { get; set; } = 1; public int UpgradeCost { get; set; } = 2; - public ITowerTypeData AfterUpgradeType { get; set; } = null; + public ITowerTypeData AfterUpgradeType { get; set; } } } } diff --git a/Assets/Scripts/Presentation/UI/MainMenu.cs b/Assets/Scripts/Presentation/UI/MainMenu.cs index ce5f73d..3d33e16 100644 --- a/Assets/Scripts/Presentation/UI/MainMenu.cs +++ b/Assets/Scripts/Presentation/UI/MainMenu.cs @@ -46,7 +46,7 @@ public class MainMenu : MonoBehaviour { textContent.Clear(); foreach (string entry in gameRules.Split('\n')) { bool isTitle = entry.StartsWith("#"); - var label = new Label() { text = isTitle ? entry.Substring(1) : entry }; + var label = new Label { text = isTitle ? entry.Substring(1) : entry }; label.AddToClassList(isTitle ? TitleStyle : ParagraphStyle); textContent.Add(label); } diff --git a/Assets/Scripts/Presentation/UI/TowerPlacingUI.cs b/Assets/Scripts/Presentation/UI/TowerPlacingUI.cs index 23db441..5986fa6 100644 --- a/Assets/Scripts/Presentation/UI/TowerPlacingUI.cs +++ b/Assets/Scripts/Presentation/UI/TowerPlacingUI.cs @@ -168,7 +168,7 @@ public class TowerPlacingUI : MonoBehaviour { private void ShowTowerTypeStats(ITowerData towerType, VisualElement statsContainer) { statsContainer.Clear(); if (towerType != null) { - string[] stats = new[] { + string[] stats = { $"Damage: {towerType.Damage}", $"Range: {towerType.Range}", $"Building Cost: {towerType.BuildingCost}", $"Destroy Refund: {towerType.DestroyRefund}", $"Cooldown Time: {towerType.CooldownTime}", $"UpgradeCost: {towerType.UpgradeCost}" @@ -255,7 +255,7 @@ public class TowerPlacingUI : MonoBehaviour { public event Action<Tower> OnTowerUpgraded; /// <summary> - /// Invoked when the next button is clicke + /// Invoked when the next button is clicked /// </summary> public event Action OnNextClicked; -- GitLab